-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CDN usage #570
Fix CDN usage #570
Conversation
what about downloading them and making them part of the repo with bower/grunt or even component and combine them truly? |
@cordoval that could possibly encourage people to make changes directly in files (example edit bootstrap css) instead of using their own css |
?? no @pborreli those files are symlinked or moved with bower/component, they are not versioned together, and in any case the approach should make clear they shouldn't be changing cdn files. I mean it is not the greatest practice anyway and for that they have frontend.css |
well as you want, my preference is CDN way but it's only my own point of view |
lol, not against your view, just my view too, if say i am in an airplane or somewhere remote without wifi then i don't need it to develop. But is not as I wish, but as they wish 👶 Let's wait and see. |
if you are in an airplane without wifi, you can't dump assets as Assetic will try to download files from CDN to combine them. |
correct, but if they are already downloaded with composer+component then they will just be added and combined right? of course you ran composer before while on earth. |
right now the combine is only made during sylius:install not by run-scripts during composer update/install but yes, once it's done, you don't need internet anymore if you don't make any changes in css/js |
I'd love to do it right, with Bower... but this introduces requirement for node.js on the server, am I right? |
🐼 |
IMHO CDN assets shouldn't be download by assetic and combined.
Right now even if they are combined, browser still downloads linked images anyway ..