[BC Break][Content] Remove Assetic and CMFMenuBundle #5734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +40,7 @@ Feature: Viewing product's attributes | |||
| Given the store has a product "T-shirt banana" | |||
| And this product has datetime attribute "T-shirt date of production" with date "12 December 2015 12:34" | |||
| When I check this product's details | |||
| Then I should see the product attribute "T-shirt date of production" with value "Dec 12, 2015 12:34:00 PM" | |||
| Then I should see the product attribute "T-shirt date of production" with value "Dec 12, 2015, 12:34:00 PM" | |||
There was a problem hiding this comment.
I believe it's platform dependent.
Zales0123
force-pushed
the
remove-assetic
branch
3 times, most recently
from
86aa437
to
21233a8
Compare
|
@Zales0123 Could you also remove menu bundle from composer.json and kernel? :> |
Zales0123
force-pushed
the
remove-assetic
branch
from
21233a8
to
4ef6552
Compare
Zales0123
force-pushed
the
remove-assetic
branch
from
4ef6552
to
27c5b32
Compare
|
Thanks Mateusz! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a completion of #5593