Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Twig] Use the right date filter #6519

Closed
wants to merge 4 commits into from
Closed

[Twig] Use the right date filter #6519

wants to merge 4 commits into from

Conversation

lologhi
Copy link

@lologhi lologhi commented Oct 24, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets
License MIT

Because while running assetic:dump command I always have:

The template "SyliusResourceBundle::layout.html.twig" contains an
error: Unknown "format_date" filter. Did you mean "format_file" in
"SyliusResourceBundle::layout.html.twig" at line 50

Because while running `assetic:dump` command I always have:

```
The template "SyliusResourceBundle::layout.html.twig" contains an
error: Unknown "format_date" filter. Did you mean "format_file" in
"SyliusResourceBundle::layout.html.twig" at line 50
```
@Zales0123
Copy link
Member

I think you should not even use assetic:dump, as we dropped support for assetic in this PR.

@lchrusciel
Copy link
Member

It is not a proper fix. format_date is a proper filter, but it is provided by SonataIntlBundle. If you receive such an error it means, that we have forgotten to add it to requirements. I will open PR with this solution.

@lologhi
Copy link
Author

lologhi commented Oct 24, 2016

Oh, great! Thx @lchrusciel ! I close this one.

@pamil
Copy link
Contributor

pamil commented Oct 24, 2016

Why? As mentioned #6521, there is no reason to require SonataIntlBundle just for this one filter, that can be successfully replaced by date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants