[Admin][Taxon] Taxon image unique code validation #6183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Sep 22, 2016
•
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | |
| License | MIT |
GSadee
changed the title
GSadee
force-pushed
the
taxon-image-unique-code
branch
from
7b2282d
to
d47f42d
Compare
GSadee
changed the title
GSadee
force-pushed
the
taxon-image-unique-code
branch
from
d47f42d
to
06d8069
Compare
| @@ -67,6 +76,8 @@ public function iWantToCreateANewTaxon() | |||
| */ | |||
| public function iWantToModifyATaxon(TaxonInterface $taxon) | |||
| { | |||
| $this->sharedStorage->set('taxon', $taxon); | |||
There was a problem hiding this comment.
Do we need to set it?
| <option name="fields"> | ||
| <value>code</value> | ||
| <value>owner</value> | ||
| </option> |
There was a problem hiding this comment.
We should also add this constraint on the database level.
There was a problem hiding this comment.
And we already have this constraint: https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/CoreBundle/Resources/config/doctrine/model/TaxonImage.orm.xml#L21
GSadee
force-pushed
the
taxon-image-unique-code
branch
from
06d8069
to
d342079
Compare
GSadee
force-pushed
the
taxon-image-unique-code
branch
from
d342079
to
4fa0b74
Compare
|
Thanks Grzesiu! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Admin][Taxon] Taxon image unique code validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.