-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin][Product] Product image unique code validation #6215
Merged
michalmarcinkowski
merged 3 commits into
Sylius:master
from
GSadee:product-image-code-unique
Sep 28, 2016
Merged
[Admin][Product] Product image unique code validation #6215
michalmarcinkowski
merged 3 commits into
Sylius:master
from
GSadee:product-image-code-unique
Sep 28, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15d0cf1
to
a399e2e
Compare
Scenario: Unable to change an image's code of a simple product | ||
Given the store has a product "Lamborghini Gallardo Model" | ||
And this product has an image "lamborghini.jpg" with a code "thumbnail" | ||
And I want to modify this product |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And
-> When
Scenario: Unable to change an image's code of a configurable product | ||
Given the store has a "Lamborghini Gallardo Model" configurable product | ||
And this product has an image "lamborghini.jpg" with a code "thumbnail" | ||
And I want to modify this product |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
@GSadee rebase needed. |
a399e2e
to
9446752
Compare
9446752
to
7730701
Compare
Thanks Grzesiu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on one commit from #6183