Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin][Product] Product image unique code validation #6215

Merged
merged 3 commits into from
Sep 28, 2016

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Sep 26, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related tickets
License MIT

This PR is based on one commit from #6183

@GSadee GSadee changed the title [WIP][Admin][Product] Product image unique code validation [Admin][Product] Product image unique code validation Sep 26, 2016
Scenario: Unable to change an image's code of a simple product
Given the store has a product "Lamborghini Gallardo Model"
And this product has an image "lamborghini.jpg" with a code "thumbnail"
And I want to modify this product
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And -> When

Scenario: Unable to change an image's code of a configurable product
Given the store has a "Lamborghini Gallardo Model" configurable product
And this product has an image "lamborghini.jpg" with a code "thumbnail"
And I want to modify this product
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@michalmarcinkowski
Copy link
Contributor

@GSadee rebase needed.

@michalmarcinkowski michalmarcinkowski merged commit 3c9aa54 into Sylius:master Sep 28, 2016
@michalmarcinkowski
Copy link
Contributor

Thanks Grzesiu!

@GSadee GSadee deleted the product-image-code-unique branch September 22, 2017 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants