Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fixed OrderInventoryOperator to take into account refunded payments #7273

Merged
merged 1 commit into from
Jan 18, 2017
Merged

[Core] Fixed OrderInventoryOperator to take into account refunded payments #7273

merged 1 commit into from
Jan 18, 2017

Conversation

NoResponseMate
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets fixes #7144
License MIT

@NoResponseMate NoResponseMate force-pushed the fix/refund-canceled-order-inventory-issue branch from 5a8437b to 44462f7 Compare January 17, 2017 12:37
@NoResponseMate
[Core] Updated OrderInventoryOperator
5ee42e6 
Provided it returns the item quantity of a refunded order ot inventory, instead of throwing an exception.
@NoResponseMate NoResponseMate force-pushed the fix/refund-canceled-order-inventory-issue branch from 44462f7 to 5ee42e6 Compare January 17, 2017 12:53
@pjedrzejewski pjedrzejewski merged commit d42ad7b into Sylius:master Jan 18, 2017
@pjedrzejewski
Copy link
Member

Thank you Łukasz!

@pjedrzejewski
Copy link
Member

pjedrzejewski commented Jan 18, 2017 •
edited
Loading

I meant Jasiek of course. Sorry! :) At least this proves I type all these thank yous manually! :D

@NoResponseMate NoResponseMate deleted the fix/refund-canceled-order-inventory-issue branch January 18, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@michalmarcinkowski michalmarcinkowski michalmarcinkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Order] Exception when cancelling an order because not enough units to give back
4 participants
@NoResponseMate @pjedrzejewski @GSadee @michalmarcinkowski