[RFC][WIP] Expose product option information in API #7547
Conversation
There was a problem hiding this comment.
Thanks Andreas for contributing! we really appreciate it.
But this part of API will be also reworked #7482. At least presenting ProductOptions. Maybe you would like to base your work on that PR?
Exposing a whole translation array should resolve the problem, as it is a stateless approach. Probably, the exception is thrown, because we didn't have any locale defined at all.
Anyway, if you need some insight into project or any help, feel free to ask or join us at our Slack :)
| values: | ||
| expose: true | ||
| virtual_properties: | ||
| getName: |
There was a problem hiding this comment.
Instead of fetching the name with virtual property, we should expose all product option translations
| virtual_properties: | ||
| getName: | ||
| serialized_name: name | ||
| getValue: |
There was a problem hiding this comment.
Same as above. Both virtual properties should be removed and we should expose all translations
|
Thanks for the quick reply, Łukasz. I'll hold off until #7482 is merged and then rebase and continue working on this. |
|
Superseded by #7811. |
The serializer configuration for product options currently does not correctly expose values: options only expose their codes, no names, no values. The
nameproperty is no longer used, instead this should be a virtualgetName. The same goes for option values, affecting thevalueattribute.Unfortunately, exposing option values triggers an error when creating a new option. The
ProductOptionValueTypecreates a newProductOptionValueobject through the formsempty_dataclosure. However, the resulting object has no locale information, so when the result of the create is serialized, the following error occurs:Obviously, the forms should create new objects not through the default
empty_datafunction, but rather through the respective resource factory. Since such a change affects all form classes and might be considered a BC break (it involves adding a requiredfactoryargument toAbstractResourceType::__construct), I wanted to get some input on the issue before going out and changing all forms and services. What do you think?