Allow writing product options via API #7811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
modify-product-options-api
branch
from
d954c9d
to
6cff941
Compare
Zales0123
approved these changes
Mar 23, 2017
| @@ -85,6 +93,246 @@ public function it_allows_showing_product_option() | |||
| } | |||
|
|
|||
| /** | |||
| * @test | |||
| */ | |||
| public function it_does_not_allow_delete_product_option_if_it_does_not_exist() | |||
There was a problem hiding this comment.
it_does_not_allow_delete -> it_does_not_allow_to_delete
| /** | ||
| * @test | ||
| */ | ||
| public function it_allows_delete_product_option() |
There was a problem hiding this comment.
it_allows_delete -> it_allows_deleting/it_allows_to_delete
| /** | ||
| * @test | ||
| */ | ||
| public function it_allows_create_product_option_with_multiple_translations() |
There was a problem hiding this comment.
it_allows_create -> it_allows_to_create
alcaeus
force-pushed
the
modify-product-options-api
branch
from
6cff941
to
c1641f1
Compare
|
Made the changes suggested - thanks for the quick approval! |
tuka217
approved these changes
Mar 23, 2017
|
Thank you Andreas, nice work! We will also need documentation, could you submit a separate PR? |
|
@pjedrzejewski Sure thing, I'd combine it with the docs for #7816 if that's alright with you? |
|
@alcaeus Sure! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Allow writing product options via API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #7547. It exposes the
translationsproperty for product options to the API. It also re-introduces creating, updating and deleting product options via the API, which was removed in #7482.