[CoreBundle] Add payment state to order, to allow easier access & sorting #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting Also add some randomness into order fixtures
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 14, 2014
[CoreBundle] Add payment state to order, to allow easier access & sorting
|
Thank you! |
|
uhm sorry I don't see the point for this redundancy? It's only a bit easier to manipulate, whereas it adds a column to the already big enough order table. |
|
@winzou I should have clarified, our goal is to support multiple payments per order. This state will work just like the shipping state. If all payments are successful and the balance is 0, the order is marked as paid. It can be partially paid... balance due, credit owed and so on. |
|
@winzou It's first step for this #834 which will be exactly what @pjedrzejewski wrote in comment above =) |
|
In that case, 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add some randomness into order fixtures