[Shipping] Scalar types in Shippings #8440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Aug 23, 2017
Zales0123
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | #8425 |
| License | MIT |
30 tasks
Zales0123
added
BC Break
Zales0123
force-pushed
the
scalar-types-shipping
branch
from
11e9209
to
d0b01d3
Compare
pamil
suggested changes
Aug 24, 2017
| @@ -203,7 +203,7 @@ public function getInventoryName() | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function getShippingCategory() | |||
| public function getShippingCategory(): ? ShippingCategoryInterface | |||
| @@ -111,27 +111,27 @@ function its_height_is_mutable() | |||
| function it_returns_correct_shipping_weight() | |||
| { | |||
| $this->setWeight(140); | |||
| $this->getShippingWeight()->shouldReturn(140); | |||
| $this->getShippingWeight()->shouldReturn(140.00); | |||
There was a problem hiding this comment.
It looks weird, setting 140 and expecting 140.00
| @@ -185,7 +185,7 @@ public function getShippables() | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function getShippingWeight() | |||
| public function getShippingWeight(): int | |||
There was a problem hiding this comment.
Isn't $unit->getShippable()->getShippingWeight() float?
| @@ -23,25 +23,25 @@ | |||
| /** | |||
| * @return int | |||
| */ | |||
| public function getShippingWeight(); | |||
| public function getShippingWeight(): int; | |||
There was a problem hiding this comment.
I guess we have a mismatch in storing weight / depth etc. Once at a time it's a float, another time it's an integer.
pamil
approved these changes
Aug 24, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.