[Taxation] Scalar types in Taxes #8451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Aug 24, 2017
Zales0123
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | #8425 |
| License | MIT |
Zales0123
added
BC Break
30 tasks
pamil
suggested changes
Aug 25, 2017
| @@ -3,16 +3,16 @@ | |||
| <div class="divider"> / </div> | |||
| {% if product.mainTaxon is not null %} | |||
| {% set taxon = product.mainTaxon %} | |||
| {% set parents = taxon.parents|reverse %} | |||
| {#{% set parents = taxon.parents|reverse %}#} | |||
| */ | ||
| public function setName($name); | ||
| public function setName(string $name): void; |
|
|
||
| * The following methods does not longer have a default null argument and requires one to be explicitly passed: | ||
|
|
||
| * `TaxRateInterface::setTranslatable` |
There was a problem hiding this comment.
Also TaxRateInterface::setCategory
Zales0123
force-pushed
the
scalar-types-taxation
branch
from
3e5ee6b
to
897805c
Compare
pamil
suggested changes
Aug 25, 2017
| @@ -53,7 +53,7 @@ public function getAmount(): float; | |||
| public function getAmountAsPercentage(): float; | |||
|
|
|||
| /** | |||
| * @param float|null $amount | |||
| * @param float $amount | |||
| @@ -175,9 +175,9 @@ public function setCalculator(?string $calculator): void | |||
| } | |||
|
|
|||
| /** | |||
| * @return string|null | |||
| * @return string | |||
Zales0123
force-pushed
the
scalar-types-taxation
branch
from
897805c
to
7af58bb
Compare
pamil
approved these changes
Aug 25, 2017
|
Thank you Zaleś! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.