[Order] Use typehints introduced by PHP7+ #8473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pamil
commented
Aug 28, 2017
pamil
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | part of #8425 |
| License | MIT |
pamil
added
BC Break
30 tasks
pamil
force-pushed
the
scalar-types/order
branch
4 times, most recently
from
2eb30dc
to
1ae9875
Compare
Zales0123
reviewed
Aug 30, 2017
|
|
||
| /** | ||
| * @param AdjustableInterface|null $adjustable | ||
| */ | ||
| public function setAdjustable(AdjustableInterface $adjustable = null); | ||
| public function setAdjustable(?AdjustableInterface $adjustable): void; |
There was a problem hiding this comment.
We should mention this in UPGRADE.md file
| */ | ||
| public function setOrder(OrderInterface $order = null); | ||
| public function setOrder(?OrderInterface $order): void; |
| */ | ||
| public function setCheckoutCompletedAt(\DateTimeInterface $checkoutCompletedAt = null); | ||
| public function setCheckoutCompletedAt(?\DateTimeInterface $checkoutCompletedAt): void; |
There was a problem hiding this comment.
And this and everything else where we remove the default value from public method.
pamil
force-pushed
the
scalar-types/order
branch
from
1ae9875
to
a861962
Compare
Zales0123
approved these changes
Aug 30, 2017
|
Thank you Kamil! 🥇 |
|
Thank you for this medal, it means so much for me! |
bendavies
pushed a commit
to bendavies/Sylius
that referenced
this pull request
Sep 7, 2017
[Order] Use typehints introduced by PHP7+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.