Prevent guest orders hijacking #8586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
Bug Fix
Critical
pamil
approved these changes
Sep 11, 2017
|
Thanks Mateusz, nice work! |
lchrusciel
reviewed
Sep 11, 2017
| And I select "Offline" payment method | ||
| And I complete the payment step | ||
| And I confirm my order | ||
| And I register with previously used "ned@stark.com" email and "lannistersAreDumb" password |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was, that if we change email address in addressing checkout step, it was changed in customer entity. The quick fix for that is to create a new
Customerif email is changed. It would sadly result in unneededCustomers with wrong email in database, but it's still much better than current bug 😄