Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing address forms from backend user form #890

Merged
merged 2 commits into from
Jan 24, 2014

Conversation

Richtermeister
Copy link
Contributor

The reason is that the address requirement makes it difficult to add non-customer users (admins) to the system.
In another PR we should probably expose address-book functionality in the backend.

@pjedrzejewski
Copy link
Member

You need to update the scenarios. (removing the address steps)

I wanted to do this recently, we should have address book for every customer. (just like in the account section)

@pjedrzejewski
Copy link
Member

@Richtermeister It conflicts with your other PR I just merged. :)

@Richtermeister
Copy link
Contributor Author

@pjedrzejewski Hehe, yeah, I had a hunch it would, but to be honest, Travis is faster at running Behat than my laptop is, so now I know where to look :)

@stloyd
Copy link
Contributor

stloyd commented Jan 23, 2014

@Richtermeister You don't need to run whole Behat suite every time at your laptop, just start one or few profiles that are "changed" by your PR =)

@Richtermeister
Copy link
Contributor Author

@pjedrzejewski Conflict resolved (I hope, required rebasing..).

pjedrzejewski pushed a commit that referenced this pull request Jan 24, 2014
Removing address forms from backend user form
@pjedrzejewski pjedrzejewski merged commit 2d93db4 into Sylius:master Jan 24, 2014
@pjedrzejewski
Copy link
Member

Thanks Daniel! 👍

@Richtermeister Richtermeister deleted the admin-create-customer branch January 24, 2014 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants