Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document "event" option in resource routing #9466

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

Zales0123
Copy link
Member

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Pretty straight-forward documentation right now, but it's still better than nothing 😄

@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jun 7, 2018
Custom Event Name
-----------------

By default, there are two events thrown during resource creation, one before adding it do database, the other after successful addition.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"thrown" -> "triggered"? Thrown sounds like an exception :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "dispatched"? Would be the most accurate, I think :)

@Zales0123 Zales0123 changed the base branch from master to 1.0 June 7, 2018 14:36
@lchrusciel lchrusciel merged commit 376cd40 into Sylius:1.0 Jun 8, 2018
@lchrusciel
Copy link
Member

Thanks Mateusz! 🐋

@Zales0123 Zales0123 deleted the docs/resource-event branch June 8, 2018 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants