Handle null email in oauth login #9612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
approved these changes
Jul 24, 2018
|
@lchrusciel spec has been added |
Zales0123
reviewed
Jul 25, 2018
| } | ||
| } else { |
There was a problem hiding this comment.
I think we don't need that else
| $userManager->persist($user)->shouldNotBeCalled(); | ||
| $userManager->flush()->shouldNotBeCalled(); | ||
|
|
||
| $this->shouldThrow(UsernameNotFoundException::class)->during('loadUserByOAuthUserResponse', [$response]); |
There was a problem hiding this comment.
There is a lot of unnecessary code there :) The only required is:
$response->getResourceOwner()->willReturn($resourceOwner);
$resourceOwner->getName()->willReturn('google');
$response->getUsername()->willReturn('username');
$oauthRepository->findOneBy(['provider' => 'google', 'identifier' => 'username'])->willReturn(null);
$response->getEmail()->willReturn(null);
$userRepository->findOneByEmail(Argument::any())->shouldNotBeCalled();
$this->shouldThrow(UsernameNotFoundException::class)->during('loadUserByOAuthUserResponse', [$response]);
|
@Zales0123 changes done :) |
pamil
approved these changes
Jul 26, 2018
pamil
added
the
Potential Bug
|
Thanks! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user tries to log in with Facebook but chooses to not give their email, Sylius crashes because it attempts to insert a user with null email into the database. This PR fixes this by checking this case in the user provider.