Use PHP7.4 syntax #210
Merged
Use PHP7.4 syntax #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Zales0123
force-pushed
the
php7.4-syntax
branch
from
a036ce3
to
02cfbad
Compare
Zales0123
commented
Oct 11, 2021
| @@ -14,19 +14,16 @@ | |||
|
|
|||
| final class ManagingAdministratorsContext implements Context | |||
| { | |||
| /** @var NotificationCheckerInterface */ | |||
| private $notificationChecker; | |||
| private ?NotificationCheckerInterface $notificationChecker; | |||
There was a problem hiding this comment.
Don't ask me why 🤷 But build is complaining about context's dependencies being null sometimes and I believe it's better to make them nullable for now, than to delay this PR 🖖
|
Thanks, Mateusz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Sylius/Sylius#12891