Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP 7.4 syntax #328

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Use PHP 7.4 syntax #328

merged 2 commits into from
Aug 13, 2021

Conversation

Zales0123
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Better late than never 馃拑 I think we should upgrade the PHP syntax whenever we decide to bump the lowest PHP supported version (we would probably be bumping to PHP8.0 in the nearest months, which will also be a good opportunity to improve our codebase 馃殌).

@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Aug 13, 2021
@Zales0123 Zales0123 requested a review from a team as a code owner August 13, 2021 10:31
@lchrusciel lchrusciel merged commit aeadf9e into Sylius:master Aug 13, 2021
@lchrusciel
Copy link
Member

Thank you, Mateusz! 馃

@Zales0123 Zales0123 mentioned this pull request Aug 13, 2021
10 tasks
@Zales0123 Zales0123 deleted the use-php-7.4-syntax branch August 13, 2021 11:30
GSadee added a commit to Sylius/SyliusGridBundle that referenced this pull request Aug 16, 2021
This PR was merged into the 1.10-dev branch.

Discussion
----------

The same as in Sylius/SyliusResourceBundle#328 馃帀 

Commits
-------

be1a7d3 Upgrade required dependencies
017a91a Use PHP 7.4 syntax (finally)
@loic425 loic425 mentioned this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants