Move some namespaces on Exceptions #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Nov 2, 2023
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
diimpp
reviewed
Nov 2, 2023
|
|
||
| namespace Sylius\Resource\Exception; | ||
|
|
||
| final class VariantWithNoOptionsValuesException extends \Exception |
There was a problem hiding this comment.
Why this exception is necessary in sylius/resource, which doesn't know anything about variants?
There was a problem hiding this comment.
I don't know bro... should be on Product package I think
loic425
force-pushed
the
move-component-namespace/exception
branch
from
522bca7
to
faf5da4
Compare
|
@diimpp I've just rebased this PR to solve conflicts but I still have to work on your suggestions. |
loic425
force-pushed
the
move-component-namespace/exception
branch
from
660d7dd
to
a70297e
Compare
|
@diimpp @lchrusciel I've fixed conflicts again on this one. |
This was referenced Apr 9, 2024
diimpp
reviewed
Apr 11, 2024
| @@ -22,6 +24,16 @@ function it_extends_an_exception(): void | |||
| $this->shouldHaveType(\Exception::class); | |||
| } | |||
|
|
|||
| function it_is_a_runtime_exception(): void | |||
There was a problem hiding this comment.
Should it be aliased instead and those new checks moved to new target namespace?
There was a problem hiding this comment.
There are more specs, that needs to be aliased and content moved to new target namespace.
loic425
force-pushed
the
move-component-namespace/exception
branch
from
2e265a9
to
cc473c0
Compare
diimpp
approved these changes
Apr 16, 2024
|
Thank you, @loic425! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.