[Maintenance] Add an exception for unavailable storages #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoResponseMate
added
Enhancement
NoResponseMate
force-pushed
the
add-storage-exception
branch
from
ef693ee
to
fcc6f73
Compare
diimpp
previously requested changes
Apr 11, 2024
| @@ -13,7 +13,9 @@ | |||
|
|
|||
| namespace Sylius\Bundle\ResourceBundle\Storage; | |||
|
|
|||
| use Sylius\Component\Resource\Exception\StorageUnavailableException; | |||
There was a problem hiding this comment.
Since there is ongoing initiative to move namespaces in 1.11, new exception should go directly into target namespace.
Suggested change
| use Sylius\Component\Resource\Exception\StorageUnavailableException; | |
| use Sylius\Resource\Exception\StorageUnavailableException; |
| @@ -14,7 +14,9 @@ | |||
| namespace spec\Sylius\Bundle\ResourceBundle\Storage; | |||
|
|
|||
| use PhpSpec\ObjectBehavior; | |||
| use Sylius\Component\Resource\Exception\StorageUnavailableException; | |||
There was a problem hiding this comment.
Suggested change
| use Sylius\Component\Resource\Exception\StorageUnavailableException; | |
| use Sylius\Resource\Exception\StorageUnavailableException; |
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Sylius\Component\Resource\Exception; |
There was a problem hiding this comment.
If for some reason legacy exception needs to be created, then it should become class alias, otherwise please move it to src/Component/src/Exception/StorageUnavailableException
|
|
||
| namespace Sylius\Component\Resource\Exception; | ||
|
|
||
| class StorageUnavailableException extends \RuntimeException |
There was a problem hiding this comment.
Exceptions are modernized at new non-component namespace, please apply this change.
Suggested change
| class StorageUnavailableException extends \RuntimeException | |
| use Sylius\Resource\Exception\RuntimeException; | |
| class StorageUnavailableException extends RuntimeException |
| @@ -13,24 +13,39 @@ | |||
|
|
|||
| namespace Sylius\Resource\Storage; | |||
|
|
|||
| use Sylius\Component\Resource\Exception\StorageUnavailableException; | |||
There was a problem hiding this comment.
Suggested change
| use Sylius\Component\Resource\Exception\StorageUnavailableException; | |
| use Sylius\Resource\Exception\StorageUnavailableException; |
NoResponseMate
force-pushed
the
add-storage-exception
branch
from
fcc6f73
to
f7bf035
Compare
loic425
approved these changes
Apr 19, 2024
lchrusciel
approved these changes
Apr 19, 2024
|
Thank you, @NoResponseMate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of issues open Sylius regarding cli/stateless actions resulting in fatals since session is not available when resolving something within a context.
Would be nice to have a unified way of knowing whether the storage medium can be accessed at all.