Test against PHP 8, allow ECS 9 & upgrade config to PHP file

[stefandoorn]

No description provided.

[stefandoorn]

Took inspiration from #33, including the config file format change.

[Zales0123]

It fixes the build and introduces new PHP and ECS version... I like it 😄 ping @pamil as you're the boss here

[Zales0123]

ecs.php -> easy-coding-standard.php? no need to change the name

[stefandoorn]

Correct, but as we are changing the extension already, I figured we can follow the official ECS docs for the filename: https://github.com/symplify/easy-coding-standard#usage

[Zales0123]

$services
    ->set(ArraySyntaxFixer::class)
    ->call('configure', [['syntax' => 'short']])
;

it looks much better in my opinion, but maybe it's only me 🖖

[stefandoorn]

I now applied ECS actually to ecs.php & also did that in the tests. So the config needs to be compatible with the standards itself, etc. etc. etc. :-D

[stefandoorn]

cc @loevgaard took a bit of inspiration from #33 to make this PR

[loevgaard]

Nice if we can make this work :D Thanks @stefandoorn 🎉

[stefandoorn]

Ready to go @Zales0123 @pamil - WDYT?

[pamil]

What do you think about dropping ECS ^7.3 and ^8.1 and just supporting ^9.0? This PR would require a major release anyway, so we might cut down on supported packages.

[stefandoorn]

I saw many people running into an ECS error on Slack and I have it myself:

$ vendor/bin/ecs check src/ tests/
 [WARNING] You are using YAML format in "easy-coding-standard.yml" config.      
           It is deprecated and will be removed in next ECS 9. Switch to PHP    
           format as soon as possible with                                      
           "https://github.com/migrify/config-transformer"                      
 [ERROR] in_array() expects parameter 2 to be array, null given  

It seems not going to be fixed in the ECS version that we provide, so nobody will be able to get around this on older technology. This even happens on a plain project with only this requirement:

"sylius-labs/coding-standard": "^3.2"

But also on Sylius I've seen it happen on Slack.

If the ECS version is supporting anything from PHP 7.3, then I think we can be good only going with ^9.0. Users need to make a config file inclusion change etc. anyway, so it might be ok to do.

Let me know if you want me to adjust it.

[oallain]

IMHO we can just supporting Ecs ^9.0 now 👍🏻

[stefandoorn]

I've adjusted the PR to be only ECS ^9.0 :-)

[oallain]

Hello @pamil

What do you think about this latest version?

[pamil]

Thanks, Stefan! 🥇