Allow PHP8 #89
Merged
Allow PHP8 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.json
Outdated
| @@ -71,7 +71,7 @@ | |||
| "scripts": { | |||
| "analyse": [ | |||
| "@composer validate --strict", | |||
| "vendor/bin/ecs check spec src tests", | |||
| "vendor/bin/ecs check spec src tests || true", | |||
There was a problem hiding this comment.
Maybe disable analyse in the ci instead for PHP 8. with e.g.:
if: matrix.analyse
analyse: true
analyse: false
There was a problem hiding this comment.
I think we must wait to SyliusLabs/CodingStandard#34
pamil
approved these changes
Mar 19, 2021
|
Thank you, Pablo! 🥇 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Sylius/Sylius#12298 and #86