builder-tool: support -alwaysShowBuildLog option for local builds. #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cviecco
suggested changes
Sep 12, 2019
| rootDir, err := builder.BuildTreeFromManifest(srpcClient, args[0], buildLog, | ||
| logger) | ||
| logWriter := &logWriterType{} | ||
| if *alwaysShowBuildLog { |
There was a problem hiding this comment.
why dont we push these diffs into the implementaiton of the &logWriterType{} ? (maybe ioWriteCloser?)
There was a problem hiding this comment.
So, you're suggesting writing the Start... message on the first write and then add a Close() method which writes the End message and writes the file?
I could do that. I'd prefer to do that as a separate PR, as I've got a lot of pending commits. Also, I might want to make this into a library package if I can think of a nice abstraction.
There was a problem hiding this comment.
Yes.... (I will take the same response for my blank lines :))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables real-time display of build logs in builder-tool when building locally.
Minor fix for built-in help.
Fix a panic when building a tree locally, which never has a filter (bug introduced in a previous commit).