Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add twine check to make build and fix rst error #44

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Add twine check to make build and fix rst error #44

merged 2 commits into from
Jun 25, 2020

Conversation

daniellimws
Copy link
Contributor

Fix #43

Signed-off-by: Daniel Lim Wee Soong weesoong.lim@gmail.com

mithro
mithro approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniellimws @mithro
Add twine check to make build.
435847a 
Should detect errors in the README.rst file.

Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
@daniellimws @mithro
Fix rst error detected by twine / PyPi.
0d2a151 
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
@mithro
Copy link
Member

mithro commented Jun 25, 2020

@daniellimws -- I wasn't sure that your twine check was working, so I split this commit into two parts. When the first commit fails, I'll then push the second one and confirm it goes green and then merge them.

@daniellimws
Copy link
Contributor Author

@mithro Ok sure, that makes sense

@mithro
Copy link
Member

mithro commented Jun 25, 2020

Looks like it fails correctly!

adding 'sphinxcontrib_verilog_diagrams-0.0.post81.dist-info/WHEEL'
adding 'sphinxcontrib_verilog_diagrams-0.0.post81.dist-info/top_level.txt'
adding 'sphinxcontrib_verilog_diagrams-0.0.post81.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Checking dist/sphinxcontrib_verilog_diagrams-0.0.post81-py3-none-any.whl: FAILED
  `long_description` has syntax errors in markup and would not be rendered on PyPI.
    line 81: Warning: Bullet list ends without a blank line; unexpected unindent.
Checking dist/sphinxcontrib-verilog-diagrams-0.0.post81.tar.gz: FAILED
  `long_description` has syntax errors in markup and would not be rendered on PyPI.
    line 81: Warning: Bullet list ends without a blank line; unexpected unindent.
Makefile:38: recipe for target 'build' failed
make: *** [build] Error 1
The command "make build" exited with 2.
Done. Your build exited with 1.

@mithro mithro merged commit f703f53 into SymbiFlow:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readme Rst is broken
2 participants
@daniellimws @mithro