Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuation: Use yowasp_yosys instead of system-installed yosys #55

Merged
merged 5 commits into from
Sep 14, 2020
Merged

Continuation: Use yowasp_yosys instead of system-installed yosys #55

merged 5 commits into from
Sep 14, 2020

Conversation

rw1nkler
Copy link
Contributor

@rw1nkler rw1nkler commented Sep 8, 2020 •
edited

This PR is a continuation of the work that has been started in #50.
Additional changes introduced in this PR involve:

  • ability to chose between YoWASP Yosys, system Yosys, specific Yosys binary
  • tests for the mentioned cases in the Travis CI

Resolves #40
Closes #50

@daniellimws @rw1nkler
Use yowasp_yosys instead of yosys from conda
4e93e76 
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
@daniellimws @rw1nkler
Allow user to choose between yowasp and system-installed yosys
135dc83 
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
@daniellimws @rw1nkler
Fix rst syntax error
0150f15 
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
@rw1nkler
Add global variable for yosys type selection
027f374 
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler
Add tests for verilog_domain_yosys global setting
598533d 
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
mithro
mithro approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rw1nkler rw1nkler merged commit ac79fa4 into SymbiFlow:master Sep 14, 2020
@daniellimws
Copy link
Contributor

Thanks for completing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate if we can use the Yosys uploaded to PyPi
3 participants
@rw1nkler @daniellimws @mithro