Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #6

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Update README #6

merged 1 commit into from
Oct 30, 2020

Conversation

acomodi
Copy link
Collaborator

@acomodi acomodi commented Oct 28, 2020 •
edited

Signed-off-by: Alessandro Comodi acomodi@antmicro.com

Fixes #5

kgugala
kgugala reviewed Oct 28, 2020
View reviewed changes
README.md Outdated

## Usage

This script has four non-required parameters to control which bucket and which artifact to get:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional?

kgugala
kgugala reviewed Oct 28, 2020
View reviewed changes
README.md Outdated
- `--project`: name of the project/repository within the SymbiFlow organization
- `--build_name`: name of the CI that has uploaded the desired artifact
- `--jobset`: name of the jobset. This can assume two values: `presubmit`, `continuous`
- `--get_max_int`: returns also the number of the latest build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the default values here?

@acomodi
Update README
2eb737c 
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@mithro
Copy link
Member

mithro commented Oct 28, 2020

I was wonder if this would be better called "symbiflow-tools-data-manager"? It doesn't really manage packages but the data required by the packages right?

@acomodi
Copy link
Collaborator Author

acomodi commented Oct 28, 2020

@mithro Agreed. I think also that manager might be incorrect as well, as this does not manage data, but it is rather a helper to get the data.

Maybe symbiflow-tools-data-fetcher?

@mithro
Copy link
Member

mithro commented Oct 28, 2020

I think manager in the name is good -- we should expand the tool to understand what has been downloaded. (IE You have all the artix line available, etc).

@acomodi
Copy link
Collaborator Author

acomodi commented Oct 28, 2020

@mithro Ok, I'll proceed with renaming the repo than (and the README as well)

@mithro
Copy link
Member

mithro commented Oct 28, 2020

BTW -- I'm thinking this tool should probably be included as part of the symbiflow_XXXX (synth/place/etc) tooling?

@acomodi acomodi merged commit b7de233 into SymbiFlow:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgugala kgugala kgugala left review comments

@mgielda mgielda Awaiting requested review from mgielda

@rw1nkler rw1nkler Awaiting requested review from rw1nkler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update README
3 participants
@acomodi @mithro @kgugala