-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add built-in random sampling #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results
|
Pull Request Test Coverage Report for Build 7336937036
💛 - Coveralls |
MilesCranmer
force-pushed
the
builtin-sampling
branch
from
December 26, 2023 05:48
5d63ed4
to
8146597
Compare
MilesCranmer
force-pushed
the
builtin-sampling
branch
from
December 26, 2023 06:04
607d541
to
405c0c7
Compare
MilesCranmer
force-pushed
the
builtin-sampling
branch
from
December 26, 2023 06:20
f130e2b
to
b35ae60
Compare
MilesCranmer
added a commit
that referenced
this pull request
Dec 28, 2023
[Diff since v0.14.0](v0.14.0...v0.14.1) **Merged pull requests:** - Add built-in random sampling (#57) (@MilesCranmer) - Add better errors for `rand` (#58) (@MilesCranmer)
MilesCranmer
added a commit
that referenced
this pull request
Jan 25, 2024
[Diff since v0.14.0](v0.14.0...v0.14.1) **Merged pull requests:** - Add built-in random sampling (#57) (@MilesCranmer) - Add better errors for `rand` (#58) (@MilesCranmer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the random sampling of nodes into DynamicExpressions.jl. It also makes things more explicit with respect to sampling graph nodes. For example, should one sample a
GraphNode
with the same probability, or proportional to how many times it is used in upstream nodes? This allows you to choose both.TODO:
NodeSampler
to docs