Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update brushing code #164

Closed
9 of 10 tasks
dcooley opened this issue Apr 7, 2019 · 1 comment
Closed
9 of 10 tasks

update brushing code #164

dcooley opened this issue Apr 7, 2019 · 1 comment
Labels
enhancement New feature or request External Dependency Relies on external library changes

Comments

@dcooley
Copy link
Collaborator

dcooley commented Apr 7, 2019 •
edited

as per: visgl/deck.gl@af7d27e
and
https://github.com/uber/deck.gl/blob/master/docs/api-reference/extensions/brushing-extension.md

combine with #160

Design ideas

every layer gets a brush_option or brush_type, being radius, group, .. other, where

radius : highlights shapes within the radius of the mouse
group : highlights shapes with the same 'value' as the given hovered shape(s)

Then, depending on the type chosen will call the required shaders.

May need different shaders for standard and origin-destination layers

TODO

  • test on scatterplot
  • test on arc
  • add to all POINT layers
  • polygon
  • path
  • line
  • hexagon
  • greatcircle - not working in deck.gl v8.1*
  • mesh
  • implement getBrushingTarget
@SymbolixAU SymbolixAU added the enhancement New feature or request label May 1, 2019
@SymbolixAU SymbolixAU added the External Dependency Relies on external library changes label May 27, 2019
@SymbolixAU
Copy link
Collaborator

related - visgl/deck.gl#3591

SymbolixAU pushed a commit that referenced this issue Sep 18, 2019
brushing extension POC for #164
7329001
SymbolixAU pushed a commit that referenced this issue Sep 18, 2019
testing column for #164
5ec446d
dcooley added a commit that referenced this issue Feb 2, 2020
@dcooley
more brushing extensins for #164
479eb6b
@dcooley dcooley closed this as completed in 434d112 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request External Dependency Relies on external library changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcooley