Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.3 Release Tracker #3591

Closed
20 tasks done
1chandu opened this issue Sep 13, 2019 · 11 comments
Closed
20 tasks done

7.3 Release Tracker #3591

1chandu opened this issue Sep 13, 2019 · 11 comments
Assignees
Labels
Milestone

Comments

@1chandu
Copy link
Contributor

1chandu commented Sep 13, 2019

  • Bump all dependencies (math.gl, probe.gl, loaders.gl and luma.gl) latest alpha/beta/ prod versions (@1chandu)
  • Publish alpha/beta (@1chandu)
  • Bump all examples to latest alpha/beta (@1chandu)
  • Stage the website (@1chandu)
  • Verify whats-new (@tgorkin )
  • Verify upgrade-guide (@Pessimistress )
  • Verify all issues in milestone are closed or move out (@tgorkin )
  • Verify all API changes are documented (@Pessimistress )
  • Website (docs and example) testing: staging
  • Cut 7.3-release branch after all fixes
  • Update website doc urls to point to 7-3-release branch (@1chandu )
  • Update 7.3 badge to point to 7.3 branch on Overview page. (@1chandu)
  • Update luma.gl dependency to 7.3 prod (@1chandu )
  • Publish 7.3 prod version. (@1chandu )

Testing procedure

  • access staged doc website
  • go through all examples
  • verify functionality in control panels
  • look for console errors/warnings
  • add results of testing as comments on this issue
  • Test Playground (JSON Browser) (Instructions: ?? TBD)
@1chandu 1chandu added the bug label Sep 13, 2019
@1chandu 1chandu self-assigned this Sep 13, 2019
@SymbolixAU
Copy link
Contributor

I've been trying the BrushingExtension() the but keep getting the error

deck.BrushingExtension is not a constructor

I'm using https://unpkg.com/deck.gl@^7.3.0-alpha.7/dist.min.js.

The new LightingEffects seem to work fine

The snippet of code to generate the error is

  const d = new deck.DirectionalLight({
	  color: [255, 255, 255],
	  intensity: 1.0,
	  direction: [-3, -9, -1]
	});
  console.log( d );
  const b = new deck.BrushingExtension();
  console.log( b );

And here's a screenshot

Screen Shot 2019-09-16 at 8 20 25 am

@1chandu
Copy link
Contributor Author

1chandu commented Sep 16, 2019

deck only re-exports everything from @deck.g;/core and @deck.gl/layers sub modules, BrushingExtension is defined in '@deck.gl/extensions' and not re exported.

@Pessimistress
Copy link
Collaborator

deck only re-exports everything from @deck.g;/core and @deck.gl/layers sub modules

The pre-bundled version does re-export everything except react and test-utils. It was a bug not including extensions. This was patched in 7.2.4 but we haven't published a new 7.3 alpha yet.

This was referenced Sep 16, 2019
@SymbolixAU
Copy link
Contributor

SymbolixAU commented Sep 18, 2019

I just tested 7.3.0-beta.1 and it works. Really well - great feature!

@Pessimistress
Copy link
Collaborator

Pessimistress commented Sep 21, 2019

Website test on iOS:

Screen Shot 2019-09-24 at 2 14 25 PM

@tsherif
Copy link
Contributor

tsherif commented Sep 23, 2019

Edge testing: No issues.

@tsherif
Copy link
Contributor

tsherif commented Sep 23, 2019

  • IE: Site doesn't load. It's crashing on a const declaration in the bundle. (@Pessimistress)

@1chandu
Copy link
Contributor Author

1chandu commented Sep 23, 2019

Firefox:

  • Line Layer (exists in 7.2 too and also occurs in chrome) : some overlapping lines are in black color (won't fix)

Screen Shot 2019-09-23 at 10 30 59 AM

  • Tile3DLayer: several messages in console like : Tile load cancelled (@xintongxia)

  • Playground (@ibgreen)

    • ScreenGridLayer crashes (website version is fine)
    • PlotLayer : just renders all white. (no errors/warnings in console)

@ajduberstein
Copy link
Collaborator

ajduberstein commented Sep 23, 2019

Chrome:

  • Color pickers work in the layer documentation don't seem to work, e.g., this example's autoHighlight. Worth noting that the color picker works in this example. (@Pessimistress)

  • Z-fighting in the scatterplot example, though I'm unsure if this is an error: (won't fix)
    image

  • Text sizing on the CPUGridLayer: (@ajduberstein)

image

Also affects GridLayer documentation

  • Might not be an error but the color palette might need to be changed in LineLayer:

image

  • Not explicitly an error but rapidly increasing the radius on the HeatmapLayer locks my browser for about 30 seconds. (@1chandu)

  • Tile3DLayer gives 9,479 logged instances of Tile load cancelled. The visualization itself seems patchy. Not my browser test but it appears not to render at all on Safari. (traversal issue won't fix for now)

image

  • Nit: Not a visualization error but Playground under Declarative Layers links to the full path of https://deck.gl/json instead of the relative path of /json (@ajduberstein)

@1chandu
Copy link
Contributor Author

1chandu commented Sep 25, 2019

Update on iOS crash:
With beta.6, the crash is fixed, but on the iOS device I only see single color instead of full spectrum, also blending seems wrong :
IMG_A8A64ABE7AFD-1

From #3554 , @tsherif mentioned there could be a bug in ANGLE implementaiton that is affecting windows machine similarly (i.e only showing one color).

I debugged this more, and see the max weight calculation is always 0, could be an issue specific to KDE implementation / additive blending that is only affecting iOS device and windows.

@1chandu
Copy link
Contributor Author

1chandu commented Sep 27, 2019

HeatmapLayer rendering issues are root caused to ANGLE , when using 1X1 Texture as render target, until this issue is fixed by ANGLE, adding weightsDomain so custom domain can be specified as a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants