RFC: Add translations for exception reasons #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocharsky-bw
commented
Jan 28, 2022
| @@ -14,5 +14,8 @@ | |||
| */ | |||
| interface ResetPasswordExceptionInterface extends \Throwable | |||
| { | |||
| public const MESSAGE_PROBLEM_VALIDATE = 'There was a problem validating your password reset request'; | |||
| public const MESSAGE_PROBLEM_HANDLE = 'There was a problem handling your password reset request'; | |||
There was a problem hiding this comment.
Those strings are hardcode in Maker - probably we could migrate them in this bundle as well and then just reuse these constants in Maker, see https://github.com/symfony/maker-bundle/blob/085358c107a7047b4889455d7518d0dbf55169f1/src/Resources/skeleton/resetPassword/ResetPasswordController.tpl.php#L160
…into translate-exceptions
jrushlow
approved these changes
Jan 31, 2022
|
Related PR to Maker bundle created: symfony/maker-bundle#1059 |
Merged
weaverryan
added a commit
to symfony/maker-bundle
that referenced
this pull request
Feb 16, 2022
…ded by ResetPasswordBundle (bocharsky-bw) This PR was squashed before being merged into the 1.0-dev branch. Discussion ---------- [make:reset-password] Translate exception reasons provided by ResetPasswordBundle If there's `Symfony\Contracts\Translation\TranslatorInterface` service available in the project - Maker will generate a slightly different controller's code to inject translator service and translate exception reasons out of the box. Available after: SymfonyCasts/reset-password-bundle#206 Commits ------- b771178 [make:reset-password] Translate exception reasons provided by ResetPasswordBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202
The next step - I'll create a PR in Maker bundle to wrap reasons with
Translator::trans()- then all exception messages in this bundle will be automatically translated. The remaining step - wait for more translation contributions.Basically, I explained a workaround here which can be avoided with this PR: #202 (comment)