New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better describe the purpose of displayId #55
Comments
Taking away the "Non-SEP change" label because this should really be decided by another pair of eyes. |
Hi Raik, Based on our agreement at the workshop, this would not fall into SEP category. This is only some word-smithing, and I think it is perfectly reasonable text to add to 2.0.1. The current draft is here: https://www.overleaf.com/4622108kcsdyv#/13975227/ Feel free to edit it as you have described. All issues marked 2.0.1 have been handled, but I’m just going through to make sure the validation issues that I raised are indeed implementable in the library. The implementation should be done shortly, and it has already found a few minor typos in the new updated rules. I hope to finish my pass on 2.0.1 next week, then get it back into the git repository properly and passed back to the editors for review. Chris
|
OK, re-added Non-SEP flag, and downgraded to 2.0.1 milestone. Not sure when I will get to edit the document but I put it on my to do list. |
Note: If 2.0.1 is ready to release before you get to it, we can bump it back to 2.1.1, since 2.1.0 is expected to be release shortly after 2.0.1. |
Bumping to 2.1.1 since this is not yet done, but 2.0.1 is ready for release. |
The current description of displayId (section 7.1 of spec) only states:
(The following statement about displayId being "locally unique" has been challenged (issue #42) and will be removed.)
In section 11.2 (Compliant SBOL objects), point 2 states:
Which makes displayId not quite completely optional. It becomes a bit clearer that displayId is considered the human-readable "subject ID" within the URI of an SBOL object:
Recommended rules 1015 - 1019 reinforce this idea.
However, none of this is obvious from the actual description of displayId. Furthermore, it is difficult to see a clear difference between the name field and displayId. See issue #54 asking to rename displayId.
I suggest to update the spec with a clarification along these lines:
I also suggest to ammend the description of the name field:
By way of example, the name property of a CompoentDefinition could be a gene name or similar "human-understandable" name, usually following some expert convention.
The text was updated successfully, but these errors were encountered: