Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module's documentation and tasks #1

Merged
merged 33 commits into from Jun 8, 2022
Merged

Conversation

johlju
Copy link
Collaborator

@johlju johlju commented May 28, 2022

Pull Request (PR) description

  • Update the documentation and the tasks.

This Pull Request (PR) fixes the following issues

Closes gaelcolas/Sampler#351

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

build.yaml Outdated Show resolved Hide resolved
@johlju johlju requested a review from gaelcolas May 28, 2022 18:04
@gaelcolas
Copy link
Member

Lmk when ready btw 😉

@johlju
Copy link
Collaborator Author

johlju commented May 31, 2022

Yeah. It is a bit more work to get it done. I will see if I have more time tomorrow.

Need to get configuration options for the task into build.yaml, and then fix the tests.

@johlju
Copy link
Collaborator Author

johlju commented Jun 1, 2022

@gaelcolas okay this is ready now!

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@144e042). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##             main    #1   +/-   ##
====================================
  Coverage        ?   88%           
====================================
  Files           ?     5           
  Lines           ?    67           
  Branches        ?     0           
====================================
  Hits            ?    59           
  Misses          ?     8           
  Partials        ?     0           

Copy link
Member

@gaelcolas gaelcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks awesome!

@johlju johlju merged commit 56ef048 into SynEdgy:main Jun 8, 2022
@johlju johlju deleted the fix/module branch June 8, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with Azure DevOps Repos: Decouple git tagging from Sampler.GitHubTasks
3 participants