Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Azure DevOps Repos: Decouple git tagging from Sampler.GitHubTasks #351

Closed
raandree opened this issue Feb 15, 2022 · 5 comments · Fixed by SynEdgy/Sampler.AzureDevOpsTasks#1, #380 or #381
Labels
enhancement The issue is an enhancement request.

Comments

@raandree
Copy link
Contributor

When having the code not on GitHub but on Azure DevOps Server / Service, the git version tags are not being created. This is as the task Create_ChangeLog_GitHub_PR takes care of this and this task does not work with any non-GitHub code repository.

I want to suggest to move the git tagging into a separate task that runs with any git repository. Personal access tokens should be used for authentication. The following works for GitHub, Azure DevOps Service and Azure DevOps Server.

$patBase64 = [Convert]::ToBase64String([Text.Encoding]::ASCII.GetBytes(('{0}:{1}' -f 'PAT', $PAT)))
Invoke-Utility git config http.extraheader "Authorization: Basic $patBase64"

What do you think about this?

@johlju
Copy link
Collaborator

johlju commented Feb 15, 2022

I think @gaelcolas intention was to have a Sampler.AzDOTasks and Sampler.GitlabTasks and so on... But if it possible to make this generic (not just for AzDO and GitHub) then it could be okay to move out. But I let us get @gaelcolas input first. 🙂

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Mar 20, 2022
@gaelcolas
Copy link
Owner

How far have you got with this @raandree :)

@johlju
Copy link
Collaborator

johlju commented May 20, 2022

I think it is the task Publish_release_to_GitHub that creates the preview tag by creating a release on GitHub (which connects to a tag). I guessing we need to create a new task that just creates the preview tag since AzDo does not support registering releases to tags. Task name could be Create_preview_release_git_tag?

Though we also need a new task to send in the changelog PR, task name Create_ChangeLog_PR? To support sending in a PR branch to an Azure Repo, it will be a stripped down version of the existing task Create_ChangeLog_GitHub_PR.

We should have both new tasks in a new module Sampler.AzDOTasks 🤔

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 28, 2022
@johlju
Copy link
Collaborator

johlju commented May 28, 2022

The PR #380 and PR #381 will add a task that creates preview release tags and push a bramch, and the module https://github.com/SynEdgy/Sampler.AzureDevOpsTasks will soon contain a task that creates a PR (todo is to create the actual PR from the branch from PR #381).

@johlju johlju removed the in progress The issue is being actively worked on by someone. label May 28, 2022
@johlju
Copy link
Collaborator

johlju commented Jun 8, 2022

The new module https://github.com/SynEdgy/Sampler.AzureDevOpsTasks have now been release as a preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
3 participants