Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keyValues for addFramedVertex with class type #56

Merged
merged 1 commit into from
May 5, 2019

Conversation

killje
Copy link
Contributor

@killje killje commented May 5, 2019

###--------------------------------------------------------###
feat(internal): Added keyValues for addFramedVertex with class type

Added the function <T> T addFramedVertex(final Class<T> kind, final Object... keyValues)
as a way to add key values to vertex elements. This includes tests for this new function.
###--------------------------------------------------------###

###--------------------------------------------------------###
feat(internal): Added keyValues for addFramedVertex with class type

Added the function `<T> T addFramedVertex(final Class<T> kind, final Object... keyValues)`
 as a way to add key values to vertex elements. This includes tests for this new function.
###--------------------------------------------------------###
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #56 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
+ Coverage     84.57%   84.58%   +0.01%     
- Complexity      457      458       +1     
============================================
  Files            31       31              
  Lines          1426     1427       +1     
  Branches        292      292              
============================================
+ Hits           1206     1207       +1     
  Misses           71       71              
  Partials        149      149
Impacted Files Coverage Δ Complexity Δ
...java/com/syncleus/ferma/DelegatingFramedGraph.java 94.77% <100%> (+0.03%) 59 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9bec6c...62a5007. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #56 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
+ Coverage     84.57%   84.58%   +0.01%     
- Complexity      457      458       +1     
============================================
  Files            31       31              
  Lines          1426     1427       +1     
  Branches        292      292              
============================================
+ Hits           1206     1207       +1     
  Misses           71       71              
  Partials        149      149
Impacted Files Coverage Δ Complexity Δ
...java/com/syncleus/ferma/DelegatingFramedGraph.java 94.77% <100%> (+0.03%) 59 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9bec6c...62a5007. Read the comment docs.

@freemo
Copy link
Member

freemo commented May 5, 2019

Looks good to me, I will merge.

@freemo freemo merged commit afd31b5 into Syncleus:master May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants