Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keyValues for addFramedVertex with class type #56

Merged
merged 1 commit into from
May 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/syncleus/ferma/DelegatingFramedGraph.java
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,11 @@ public <T> T addFramedVertex(final ClassInitializer<T> initializer, final Object
}
}

@Override
public <T> T addFramedVertex(final Class<T> kind, final Object... keyValues) {
return this.addFramedVertex(new DefaultClassInitializer<>(kind), keyValues);
}

@Override
public <T> T addFramedVertex(final Class<T> kind) {
return this.addFramedVertex(new DefaultClassInitializer<>(kind));
Expand Down
12 changes: 12 additions & 0 deletions src/main/java/com/syncleus/ferma/FramedGraph.java
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,18 @@ public interface FramedGraph extends AutoCloseable {
* @return The framed vertex.
*/
<T> T addFramedVertex(ClassInitializer<T> initializer, Object... keyValues);

/**
* Add a vertex to the graph
*
* @param <T> The type used to frame the element.
* @param kind
* The kind of the frame.
* @param keyValues
* the recommended object identifier
* @return The framed vertex.
*/
<T> T addFramedVertex(Class<T> kind, Object... keyValues);

/**
* Add a vertex to the graph
Expand Down
47 changes: 47 additions & 0 deletions src/test/java/com/syncleus/ferma/FramedGraphTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.junit.Test;
import org.mockito.MockitoAnnotations;
import com.syncleus.ferma.typeresolvers.PolymorphicTypeResolver;
import org.apache.tinkerpop.gremlin.structure.T;


public class FramedGraphTest {
Expand Down Expand Up @@ -214,6 +215,52 @@ public void testJavaTypingByClass() {
Assert.assertNotNull(julia.getElement().property(PolymorphicTypeResolver.TYPE_RESOLUTION_KEY).value());
}

@Test
public void testKeyValues() {
final Graph g = TinkerGraph.open();
final FramedGraph fg = new DelegatingFramedGraph(g, true, false);

final Person p1 = fg.addFramedVertex(Programmer.DEFAULT_INITIALIZER, "key", "value");
p1.setName("Bryn");

final Person p2 = fg.addFramedVertex(Person.DEFAULT_INITIALIZER, T.label, "label");
p2.setName("Julia");

final Person bryn = fg.traverse(
input -> input.V().has("key", "value")).next(Person.class);
final Person julia = fg.traverse(
input -> input.V().hasLabel("label")).next(Person.class);

Assert.assertEquals(Programmer.class, bryn.getClass());
Assert.assertEquals(Person.class, julia.getClass());

Assert.assertNotNull(bryn.getElement().property(PolymorphicTypeResolver.TYPE_RESOLUTION_KEY).value());
Assert.assertNotNull(julia.getElement().property(PolymorphicTypeResolver.TYPE_RESOLUTION_KEY).value());
}

@Test
public void testKeyValuesByClass() {
final Graph g = TinkerGraph.open();
final FramedGraph fg = new DelegatingFramedGraph(g, true, false);

final Person p1 = fg.addFramedVertex(Programmer.class, "key", "value");
p1.setName("Bryn");

final Person p2 = fg.addFramedVertex(Person.class, T.label, "label");
p2.setName("Julia");

final Person bryn = fg.traverse(
input -> input.V().has("key", "value")).next(Person.class);
final Person julia = fg.traverse(
input -> input.V().hasLabel("label")).next(Person.class);

Assert.assertEquals(Programmer.class, bryn.getClass());
Assert.assertEquals(Person.class, julia.getClass());

Assert.assertNotNull(bryn.getElement().property(PolymorphicTypeResolver.TYPE_RESOLUTION_KEY).value());
Assert.assertNotNull(julia.getElement().property(PolymorphicTypeResolver.TYPE_RESOLUTION_KEY).value());
}

@Test
public void testJavaTypingAddExplicit() {
final Graph g = TinkerGraph.open();
Expand Down