New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncplay can unknowingly uses old VLC lua script #193

Closed
Et0h opened this Issue Jul 21, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@Et0h
Copy link
Contributor

Et0h commented Jul 21, 2018

Syncplay 1.4.0 fixed issue #108 back in January 2017, preventing erroneous jumps from VLC that were caused by VLC changing the unit used for reporting position.

The Syncplay installer will place the newest version of syncplay.lua in the %PROGRAMFILES% folder which will resolve the issue. Normally this is fine, but if someone has an old version of syncplay.lua in their VLC %APPDATA% folder then VLC will use that in favour of the more recent version in %PROGRAMFILES%.

Even worse, Syncplay won't notice it's on an old version, meaning on some version mismatches it will act incorrectly without the user knowing why.

@twrist

This comment has been minimized.

Copy link

twrist commented Aug 12, 2018

For purposes of having Google return this issue to people trying to debug, these are the relevant Notifications:

[10:34:35 PM] jumped from 2d, 12:25:45 to 3d, 16:27:53  
[10:34:35 PM] jumped from 3d, 16:27:53 to 6d, 11:27:06  
[10:34:36 PM] jumped from 6d, 11:27:06 to 10:19:56 (Title 1)  
[10:34:36 PM] jumped from 10:19:56 (Title 1) to 2d, 20:17:55 (Title 1)  
[10:34:36 PM] jumped from 2d, 20:17:55 (Title 1) to 3d, 07:51:06 (Title 1)  
[10:34:36 PM] jumped from 3d, 07:51:06 (Title 1) to 5d, 06:28:55 (Title 1)  
[10:34:36 PM] jumped from 5d, 06:28:55 (Title 1) to 6d, 05:29:49 (Title 1)  
[10:34:36 PM] jumped from 6d, 05:29:49 (Title 1) to 2d, 02:56:29 (Title 2)  
[10:34:36 PM] jumped from 2d, 02:56:29 (Title 2) to 4d, 01:33:51 (Title 2)  
[10:34:37 PM] jumped from 4d, 01:33:51 (Title 2) to 5d, 00:22:30 (Title 2)  
[10:34:37 PM] jumped from 5d, 00:22:30 (Title 2) to 10:26:34 (Title 3)  
[10:34:37 PM] jumped from 10:26:34 (Title 3) to 21:55:00 (Title 3)  

This issue happened to me, even though I started using Syncplay at 1.5.3

@benplumley

This comment has been minimized.

Copy link

benplumley commented Oct 6, 2018

Just downloaded 1.6.0 and this caught me out, even though I downloaded both the application and the Lua script fresh today. The cause of this, for me, was that the script in the VLC addon repository is not up-to-date.

Edit: if the addon from the VLC repository is not needed any more, to the point where it's no longer updated (because SyncPlay can use its own copy), perhaps it should be removed from VLC's repository to prevent this from happening to new users who only discover it via VLC.

@Et0h

This comment has been minimized.

Copy link
Contributor Author

Et0h commented Nov 14, 2018

@benplumley Thank you for letting me know that the version in the VLC repository needed updating. I have now updated the version in the VLC repository.

@Et0h Et0h added the bug label Dec 9, 2018

@Et0h

This comment has been minimized.

Copy link
Contributor Author

Et0h commented Feb 2, 2019

Currently working on https://github.com/Syncplay/syncplay/commits/vlc-copy-intf to resolve this issue. If anyone wants to test it then let me know how it goes.

@Et0h

This comment has been minimized.

Copy link
Contributor Author

Et0h commented Feb 9, 2019

#220 hopefully resolves this issue.

Et0h added a commit that referenced this issue Feb 10, 2019

Merge pull request #220 from Syncplay/vlc-copy-intf to address #193
Auto copy/update syncplay.lua when running with VLC (addresses #193)

@Et0h Et0h closed this Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment