Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSyncplay can unknowingly uses old VLC lua script #193
Comments
This comment has been minimized.
This comment has been minimized.
twrist
commented
Aug 12, 2018
•
For purposes of having Google return this issue to people trying to debug, these are the relevant Notifications:
This issue happened to me, even though I started using Syncplay at 1.5.3 |
This comment has been minimized.
This comment has been minimized.
benplumley
commented
Oct 6, 2018
•
Just downloaded 1.6.0 and this caught me out, even though I downloaded both the application and the Lua script fresh today. The cause of this, for me, was that the script in the VLC addon repository is not up-to-date. Edit: if the addon from the VLC repository is not needed any more, to the point where it's no longer updated (because SyncPlay can use its own copy), perhaps it should be removed from VLC's repository to prevent this from happening to new users who only discover it via VLC. |
This comment has been minimized.
This comment has been minimized.
@benplumley Thank you for letting me know that the version in the VLC repository needed updating. I have now updated the version in the VLC repository. |
Et0h
added
the
bug
label
Dec 9, 2018
This comment has been minimized.
This comment has been minimized.
Currently working on https://github.com/Syncplay/syncplay/commits/vlc-copy-intf to resolve this issue. If anyone wants to test it then let me know how it goes. |
This comment has been minimized.
This comment has been minimized.
#220 hopefully resolves this issue. |
Et0h commentedJul 21, 2018
Syncplay 1.4.0 fixed issue #108 back in January 2017, preventing erroneous jumps from VLC that were caused by VLC changing the unit used for reporting position.
The Syncplay installer will place the newest version of syncplay.lua in the %PROGRAMFILES% folder which will resolve the issue. Normally this is fine, but if someone has an old version of syncplay.lua in their VLC %APPDATA% folder then VLC will use that in favour of the more recent version in %PROGRAMFILES%.
Even worse, Syncplay won't notice it's on an old version, meaning on some version mismatches it will act incorrectly without the user knowing why.