Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPVNet Support #246

Open
Z3ROGRAV1TYx opened this issue Jul 19, 2019 · 12 comments

Comments

@Z3ROGRAV1TYx
Copy link

commented Jul 19, 2019

Would love to have MPVNet support. It just errors when trying to use it.

@Et0h

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

I can confirm that it gives the following error:

Exception

version: MPV_ERROR_PROPERTY_NOT_FOUND

System.Exception: version: MPV_ERROR_PROPERTY_NOT_FOUND
   at mpvnet.mp.set_property_string(String name, String value, Boolean throwOnException) in D:\Projekte\CS\mpv.net\mpv.net\mpv\mp.cs:line 420
   at mpvnet.mp.ProcessCommandLine() in D:\Projekte\CS\mpv.net\mpv.net\mpv\mp.cs:line 544

I think if you want MPVNet to support Syncplay then you will need to discuss this with the MPVNet developers.

@stax76

This comment has been minimized.

Copy link

commented Aug 2, 2019

mpv.net has no switch called --version

System.Exception: version: MPV_ERROR_PROPERTY_NOT_FOUND

@stax76

This comment has been minimized.

Copy link

commented Aug 3, 2019

@Et0h

There is a property called 'mpv-version' you can get via json ipc.

@Et0h

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

@stax76 For the response I gave my first post I disabled the version check code, and I got the error message noted above. Syncplay does not communicate with mpv using JSON IPC, it uses the regular STDIN/STDOUT system.

@stax76

This comment has been minimized.

Copy link

commented Aug 4, 2019

I knew mpv reacts to keys pressed in a console window but that you can send input commands to stdin is new to me. It's hard to tell how hard it would be to replicate this in mpv.net. You seem to send --script, there would be a property called 'scripts' but it can only be set before libmpv initialization and mpv.net parses the command line after initialization. My python knowledge being only very basic don't help either, there might not be an easy way for us to make this work.

@stax76

This comment has been minimized.

Copy link

commented Aug 4, 2019

well, I figured there is input-terminal

            if (App.IsStartedFromTerminal)
            {
                set_property_string("terminal", "yes");
                set_property_string("input-terminal", "yes");
                set_property_string("msg-level", "osd/libass=fatal");
            }

maybe it's not that hard, we'll see.

@stax76

This comment has been minimized.

Copy link

commented Aug 4, 2019

I got this working... Just don't invoke an instance to get the version and try my next release.

@Et0h

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

@stax76 Nice one - it works! :)

mpvnet support can now be added to Syncplay.

@Et0h

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

Okay, initial support should be added by 187c8d8 which you can test out at https://bintray.com/syncplay/Syncplay/Syncplay/v1.6.5#files

@Et0h Et0h self-assigned this Aug 5, 2019

@Et0h

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@Z3ROGRAV1TYx Can you please test the test build of mpvnet with the test build of Syncplay and let me know if it works for you? Seems to be working fine for me.

@fmohican

This comment has been minimized.

Copy link

commented Aug 10, 2019

It's work! Smooth!!!
Tested with last version of MPV.NET (5.2.1, from github https://github.com/stax76/mpv.net/releases/tag/5.2.1 ) && V1.6.5 Dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.