Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPVNet Support #246

Closed
seniorm0ment opened this issue Jul 19, 2019 · 16 comments
Closed

MPVNet Support #246

seniorm0ment opened this issue Jul 19, 2019 · 16 comments
Assignees

Comments

@seniorm0ment
Copy link

@seniorm0ment seniorm0ment commented Jul 19, 2019

Would love to have MPVNet support. It just errors when trying to use it.

@Et0h
Copy link
Contributor

@Et0h Et0h commented Jul 19, 2019

I can confirm that it gives the following error:

Exception

version: MPV_ERROR_PROPERTY_NOT_FOUND

System.Exception: version: MPV_ERROR_PROPERTY_NOT_FOUND
   at mpvnet.mp.set_property_string(String name, String value, Boolean throwOnException) in D:\Projekte\CS\mpv.net\mpv.net\mpv\mp.cs:line 420
   at mpvnet.mp.ProcessCommandLine() in D:\Projekte\CS\mpv.net\mpv.net\mpv\mp.cs:line 544

I think if you want MPVNet to support Syncplay then you will need to discuss this with the MPVNet developers.

Loading

@stax76
Copy link

@stax76 stax76 commented Aug 2, 2019

mpv.net has no switch called --version

System.Exception: version: MPV_ERROR_PROPERTY_NOT_FOUND

Loading

@stax76
Copy link

@stax76 stax76 commented Aug 3, 2019

@Et0h

There is a property called 'mpv-version' you can get via json ipc.

Loading

@Et0h
Copy link
Contributor

@Et0h Et0h commented Aug 4, 2019

@stax76 For the response I gave my first post I disabled the version check code, and I got the error message noted above. Syncplay does not communicate with mpv using JSON IPC, it uses the regular STDIN/STDOUT system.

Loading

@stax76
Copy link

@stax76 stax76 commented Aug 4, 2019

I knew mpv reacts to keys pressed in a console window but that you can send input commands to stdin is new to me. It's hard to tell how hard it would be to replicate this in mpv.net. You seem to send --script, there would be a property called 'scripts' but it can only be set before libmpv initialization and mpv.net parses the command line after initialization. My python knowledge being only very basic don't help either, there might not be an easy way for us to make this work.

Loading

@stax76
Copy link

@stax76 stax76 commented Aug 4, 2019

well, I figured there is input-terminal

            if (App.IsStartedFromTerminal)
            {
                set_property_string("terminal", "yes");
                set_property_string("input-terminal", "yes");
                set_property_string("msg-level", "osd/libass=fatal");
            }

maybe it's not that hard, we'll see.

Loading

@stax76
Copy link

@stax76 stax76 commented Aug 4, 2019

I got this working... Just don't invoke an instance to get the version and try my next release.

Loading

@Et0h
Copy link
Contributor

@Et0h Et0h commented Aug 5, 2019

@stax76 Nice one - it works! :)

mpvnet support can now be added to Syncplay.

Loading

@Et0h
Copy link
Contributor

@Et0h Et0h commented Aug 5, 2019

Okay, initial support should be added by 187c8d8 which you can test out at https://bintray.com/syncplay/Syncplay/Syncplay/v1.6.5#files

Loading

@Et0h Et0h self-assigned this Aug 5, 2019
@Et0h
Copy link
Contributor

@Et0h Et0h commented Aug 8, 2019

@Z3ROGRAV1TYx Can you please test the test build of mpvnet with the test build of Syncplay and let me know if it works for you? Seems to be working fine for me.

Loading

@fmohican
Copy link

@fmohican fmohican commented Aug 10, 2019

It's work! Smooth!!!
Tested with last version of MPV.NET (5.2.1, from github https://github.com/stax76/mpv.net/releases/tag/5.2.1 ) && V1.6.5 Dev.

Loading

@RaXorX
Copy link

@RaXorX RaXorX commented Nov 23, 2019

image

@Restia666Ashdoll @Et0h
I'm getting this issue while using the latest mpvnet (5.4.4.0) and syncplay.

Edit: It works, even if it throws the error. Had to close the error and then the subsequent mpvnet window, after which it opened another mpvnet window which was connected with Syncplay.

Loading

@Et0h
Copy link
Contributor

@Et0h Et0h commented Nov 29, 2019

@RaXorX What version of Syncplay are you using? I tried MPVNet 5.4.4.0 on Windows 10 with Syncplay 1.6.5 pre-realse at https://bintray.com/syncplay/Syncplay/Syncplay/v1.6.5#files and it works fine.

Actually, when I say "works fine" there is one outstanding issue with Syncplay and MPVnet which I need to get to the bottom of, which is that sometimes when you try to use the in-player chat facility by pressing "enter" while a video is playing it won't let you type anything (or exit chat input mode).

Loading

@RaXorX
Copy link

@RaXorX RaXorX commented Dec 6, 2019

@Et0h v1.6.5 works fine but I was on the current stable version 1.6.4 provided from the site itself. That one threw and still throws an error as I mentioned above.

Loading

@Et0h
Copy link
Contributor

@Et0h Et0h commented May 16, 2020

I've tested mpv.net-portable-x64-5.4.8.0 with Syncplay 1.6.5.-GIT and it seems to be working fine. It would be helpful if someone else could test it too, e.g. @grravity or @RaXorX - especially the shared playlist feature and handling of EOF.

You can get MPVNet from: https://github.com/stax76/mpv.net/releases
You can get Syncplay 1.6.5-GIT from: https://bintray.com/syncplay/Syncplay/Syncplay/v1.6.5#files

Loading

@daniel-123 daniel-123 closed this Jun 3, 2020
albertosottile added a commit to albertosottile/syncplay that referenced this issue Sep 30, 2020
albertosottile added a commit to albertosottile/syncplay that referenced this issue Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants