Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around performance regression in mpv's osd

Merged
merged 1 commit into from Apr 18, 2020

Conversation

FichteFoll
Copy link
Contributor

@FichteFoll FichteFoll commented Apr 14, 2020

In mpv-player/mpv@0728726, a strcmp on
the previously displayed and the new text has been removed, causing
excessive GPU usage especially on idle frames when playback was paused.
I will submit a patch to upstream, but mpv versions 0.31 & 0.32 are
already affected by this.

See torque/mpv-progressbar#56 for a similar report to a different
script.

Note: This is just the quick fix for the preformance regression. I'll submit usage of the new API in separate PR as it would bump the minium required mpv version.

In mpv-player/mpv@0728726, a strcmp on
the previously displayed and the new text has been removed, causing
excessive GPU usage especially on idle frames when playback was paused.
I will submit a patch to upstream, but mpv versions 0.31 & 0.32 are
already affected by this.

See torque/mpv-progressbar#56 for a similar report to a different
script.
@daniel-123 daniel-123 merged commit 5f552ce into Syncplay:master Apr 18, 2020
1 check passed
@FichteFoll FichteFoll deleted the pr/smart_osd_refresh branch Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants