Re-enable youtube-dl on macOS plus mpv and IINA #381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #279. In principle, this issue should have been solved in c07206c and #360. However, a mixture of changes in the way Homebrew installs
youtube-dl
, plus a mistake in which the environment was (not) transferred to the relevant subprocess, still caused it to show up in 1.6.7.This PR re-enables the environment patching on macOS and, additionally, slightly modifies how the environment is patched to make this functional also on the arm64 architecture. Credits to @cordelac for having tested this on their machine.
Please test if this affects running mpv on Windows and Linux in any way before merging.
Closes: #379