Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement style guide roughly defined here #184
Note:
Consideration of using local imports within modules so that lib files expose only the public interface of a module
Could use the following approach for imports (src/gossip/service.zig)
const sig = https://github.com/import("../lib.zig");
const lib = struct {
const table = https://github.com/import("table.zig");
const active_set = https://github.com/import("active_set.zig");
};
const SocketAddr = sig.net.SocketAddr;
const ServiceManager = sig.utils.service_manager.ServiceManager;
const GossipTable = lib.table.GossipTable;
const HashTimeQueue = lib.table.HashTimeQueue;
const AutoArrayHashSet = lib.table.AutoArrayHashSet;