Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffsync: update to 1.8.0 #3849

Closed
wants to merge 11 commits into from

Conversation

ymartin59
Copy link
Contributor

@ymartin59 ymartin59 commented Jan 10, 2020

Motivation: Update, DMS 6 support, fix uninstall mysql password issue
Linked issues: #3124

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@ymartin59 ymartin59 changed the title 3124 update ffsync ffsync: update to 1.18.0 Jan 10, 2020
@hgy59 hgy59 mentioned this pull request Mar 18, 2020
28 tasks
@ymartin59 ymartin59 added this to In progress in Python 2.7.18 via automation Apr 5, 2020
@ymartin59 ymartin59 force-pushed the 3124-update-ffsync branch 2 times, most recently from 41a1e39 to 74f57a7 Compare April 14, 2020 07:48
@ymartin59
Copy link
Contributor Author

@hgy59 I am fighting to get it build but there is little hope, even my Debian testing is in trouble to build.
At least I have created a useful target to spare time when designing requirements file, you may be interested in: 74f57a7

@th0ma7 th0ma7 mentioned this pull request Jun 27, 2020
17 tasks
@hgy59 hgy59 mentioned this pull request Nov 3, 2020
3 tasks
@hgy59 hgy59 mentioned this pull request Dec 12, 2020
10 tasks
@hgy59 hgy59 changed the title ffsync: update to 1.18.0 ffsync: update to 1.18.0 and Python 3 Jan 24, 2021
@ymartin59
Copy link
Contributor Author

@hgy59 According to info I found in ffsync forum, there was no plan to update ffsync to Python 3.... My idea was to keep it stuck to latest Python 2 package...

@hgy59
Copy link
Contributor

hgy59 commented Jan 24, 2021

@hgy59 According to info I found in ffsync forum, there was no plan to update ffsync to Python 3.... My idea was to keep it stuck to latest Python 2 package...

But where comes the venusian==3.0.0 dependency from in requirements.txt? This package requires Python3.
This found, I thought ffsynch must be compatible with python3.

@hgy59
Copy link
Contributor

hgy59 commented Jan 24, 2021

@ymartin59 I am reverting to py2 now...

@hgy59
Copy link
Contributor

hgy59 commented Jan 25, 2021

@ymartin59 for any reason the cross build of python wheels is broken for python 2 now.
cryptography cannot be built when listed in requirements.txt due to libffi.so.7 not found.
When I add cross/cryptograpy as package dependency it builds without error, but the wheel is not copied to the share/wheelhouse ....
maybe this is related to #3956 but I have no idea how to fix it.

@hgy59 hgy59 changed the title ffsync: update to 1.18.0 and Python 3 ffsync: update to 1.8.0 Mar 14, 2021
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Sep 21, 2021
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Sep 26, 2021
th0ma7 added a commit that referenced this pull request Oct 1, 2021
* berkleydb: Update from version 6.2.23 to 6.2.32

* c_icap: Udpate from 0.2.2 to 0.5.8 and enable extra features

* squidclamav: Update from version 6.10 to 7.1

* squidguard: Update from version 1.5-beta to 1.6.0 from Debian src

* native/squid: Update from 3.1.22 to 5.0.4

* squid: Update from version 3.1.22 to 5.0.4

* squidguard: Bump version and add unsupported archs

* squid+squidguard: Fix incompatible arch mgmnt

* squidguard: Fix blacklists.tar.gz source URL

* squidguardmanager: Update from version 1.11 to 1.14

* libev: Update from version 4.22 to 4.33

* gevent: Update from version 1.2.2 to 21.1.2

* gevent: Do not use embed c-ares and libev (like previously)

* gevent: Update to version 21.8.0

* pip_py2: Update to latest python2 compatible version

* greenlet: Update to version 1.1.1 and use .tar.gz extension

* ffsync: Add cffi dependency but must be after gevent

* ffsync: Import requirements from PR #3849 (thnx @ymartin59)

* libtorrent: Fix DSM6 gcc49 build issue by adding -std=c++11

* squid: Remove shell call for file & directory name

* squidguard: Use default installation path (e.g. target)

* squidguard: Fix installation path and remove redundant prefix

* squidguard: Remove unnecessary patch now that path issue is solved

* squidguardmgr: Remove old patch no longer needed with newer version

* squidguardmgr: Fix path to squid sbin

* squidguard: Require squidclamav to test-build through cross

* squidguard: Fix path in cgi and use STAGING_INSTALL_PREFIX

* squidguard: Image thumbnails now generated by the framework

* squidguard: www now located under var

* c-icap: Dynamically update the default provided conf file

* squidguard: Fix clamd configuration paths

* squidguard: Use the now default provided errorpage.css mime.conf

* squidclamav: Use default provided config and fix clamd.ctl

* squidguard: Adjust squidguard.conf.tpl paths

* squidguard: Fix squidguardmgr.conf paths

* squid: Fix configuration paths

* squidguard: Add missing target in path

* c-icap: Update from version 0.5.8 to 0.5.9

* c-icap: Forgot to update PLIST with new lib version

* libtorrent: Enable -std=c++11 by default (also fixes comcerto2k)

Co-authored-by: hgy59 <hpgy59@gmail.com>
@th0ma7
Copy link
Contributor

th0ma7 commented Jan 10, 2022

I gave it a shot and went a long way ahead in getting it to install all python dependencies until I figure that syncsever is python2 only and is expected to be replaced by a rust version (pending for a release since quite a while now).

Should we just remove ffsync entirely?

@hgy59
Copy link
Contributor

hgy59 commented Jan 10, 2022

Should we just remove ffsync entirely?

Despite this is the last python2 package we support, I would like to keep this, until the rust version will be available in the (far ?) future.

ffsync is a cool solution and without this spk, you need a Diskstation model that supports docker to use it.

The only task that is still open is the database integration.

@hgy59
Copy link
Contributor

hgy59 commented Jan 10, 2022

@hgy59 I am fighting to get it build but there is little hope, even my Debian testing is in trouble to build. At least I have created a useful target to spare time when designing requirements file, you may be interested in: 74f57a7

@th0ma7 is the clean-wheel target something that we should regard in your wheel creation redesign - or is this contained in the spkclean target anyway?

@th0ma7
Copy link
Contributor

th0ma7 commented Jan 10, 2022

I'll give it another shot at ensuring it build OK using the new framework using python2 then. Will leave the database integration for someone else though. Note that it seems the rust version is now available https://github.com/mozilla-services/syncstorage-rs

Yeah, the clean-wheel is rather interesting and "almost" covered into spkclean. I'll try to extract it from here and implement it into another PR (and/or adjust spkclean).

hgy59 and others added 10 commits January 10, 2022 18:16
- fix download site for cross/libev
- ffsync requirements.txt exclude unittest2
- fix unittest2 version, but exclude it (unittests are not executed with cross compile)
- copy requirements.txt to staging share before patching it
- add wizard to spk
- allow empty mysql root pw in preinst (similar to preuninst)
- Change libev to 4.24
- Changed unittest2 to 0.5.1 to fix PEP 440 error
- copy requirements.txt to staging directory
- remove old files
- generic service use
Usage:  make clean-wheel ARCH=x64 TCVERSION=6.1
- depend on python3
- update greenlet for python3 compatibility
- add larger icon
- requirements.txt: update setuptools and cffi to match version of cross/package
- requirements.txt: remove packages for test
- requirements.txt: remove webencodings as not compatible with python3
- revert dependency to python2
- revert requirements for python2
- introduce resource file for db creation
- extract gevent_py2
- prepare for MariaDB10
- fix resource file
- revert changes on cross/gevent as we use cross/gevent_py2
@mreid-tt
Copy link
Contributor

mreid-tt commented Dec 4, 2023

@ymartin59, the original Firefox Sync Server, as outlined in its source repository, is no longer under active maintenance. It has undergone redevelopment in Rust and is now hosted in a new repository named Syncstorage-rs. The imminent release, linked to the Pull Request 5942 within the SynoCommunity/spksrc repository, is slated to replace all preceding versions of the package due to their deprecated functionality.

Could we kindly request the closure of this Pull Request upon the release of ours?

@mreid-tt mreid-tt closed this Dec 6, 2023
Python 2.7.18 automation moved this from In progress to Done Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Python 2.7.18
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants