Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate python mysqlclient wheel and provide default example using python310 #5068

Merged
merged 11 commits into from
Jan 22, 2022

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Jan 10, 2022

Description

While working on ffsync PR #3849 I encountered the need to figure out how to create a myselclient python wheel. Work in this PR aims to address this and provide example on how to build it for future use.

MySQL forum discussion thread: https://forums.mysql.com/read.php?117,700582,700582#msg-700582

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

Updating to using system openssl requires a migration to
mysql-connector-c++ version 8.x
Co-authored-by: hgy59 <hpgy59@gmail.com>
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jan 10, 2022

@hgy59 I was also thinking of adding mysql-connector-c++ connector as better supported (from what I'm reading) and allows using OpenSSL.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jan 16, 2022

This PR looks good for review and merge.

I wasn't able to migrate to mysql-connector-c++ (nor mariadb-connector-c++).
I'll open-up another PR to that effect with my other pending patches. Others might have clues to fix cross-compiling.

@th0ma7 th0ma7 requested a review from hgy59 January 16, 2022 13:30
@th0ma7 th0ma7 self-assigned this Jan 16, 2022
@th0ma7 th0ma7 merged commit 853a48c into SynoCommunity:master Jan 22, 2022
@th0ma7 th0ma7 deleted the python-mysqlclient branch January 22, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants