v3 CI fix hardhat not loading solc on Node18 #1760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1760 +/- ##
=======================================
Coverage 72.77% 72.77%
=======================================
Files 57 57
Lines 720 720
Branches 236 236
=======================================
Hits 524 524
Misses 167 167
Partials 29 29
*This pull request uses carry forward flags. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dbeal-eth
approved these changes
Aug 11, 2023
Node 20 LTS will start on 2023-10-24, so 18 is the way for now |
noisekit
force-pushed
the
node-18-fix-for-hardhat
branch
from
563a1de
to
f878771
Compare
noisekit
force-pushed
the
node-18-fix-for-hardhat
branch
from
f878771
to
1d54a86
Compare
|
This probably needs hardhat upgrade because on node 18 tests are randomly getting stuck forever for no apparent reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Node version to avoid hardhat silently bail with success
For context:
Hardhat randomly just silently quitting with exit code 0 when downloading solc compiler
It was an issue with NodeJS in some versions and looks like 18.16.0 is one of the affected versions (see NomicFoundation/hardhat#3877)
Using fresher (or older version of node solves it).
on
18.17.1couple of the core-utils tests are failing, so sticking to18.15.0for now.