Pulling recent changes into scons branch #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary measure until the Deluge Build Tool is done, at which point cross-platform binaries for openocd will be installed.
- Separated out the OLED vs. non-OLED builds using preprocessor declarations in e2 rather than an edit in the source. This way, build scripts will be able to choose without affecting the code. Slight modification to the code was needed to make this work. - Renamed build targets to ensure clear understanding of target meanings and mapping between targets, debug configurations, and hardware debuggers - Included openocd script and rza1.svd file for debugger configuration to use. - Configured DelugeProbe hardware debuggers in e2 and saved as shared. These rely on openocd which e2 launches itself.
Merge approved by @jamiefaye. Making it so.
Update .gitignore to exclude .DS_Store files
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 17, 2024
…or Bipolar (#1480) * Make Gold Knob LED indicators + Automation View Editor Bipolar For bipolar params: 1) Made Gold Knob LED indicators bipolar 2) Made automation view editor bipolar Also added gold knob LED indicator functionality to automation view editor that makes blinks the middle value and makes it harder to turn the knob passed the middle value * Update documentation * Address Feedback #1 * Address Feedback #2 * Address Feedback #3 * Address Feedback #4 * Address Feedback #4 - Update documentation * Address Feedback #5 * Bug fix blinking of middle knob pos Fixed bug where middle knob pos wasn't being blinked correctly for patch cables in automation view
github-actions bot
pushed a commit
that referenced
this pull request
Mar 17, 2024
…or Bipolar (#1480) * Make Gold Knob LED indicators + Automation View Editor Bipolar For bipolar params: 1) Made Gold Knob LED indicators bipolar 2) Made automation view editor bipolar Also added gold knob LED indicator functionality to automation view editor that makes blinks the middle value and makes it harder to turn the knob passed the middle value * Update documentation * Address Feedback #1 * Address Feedback #2 * Address Feedback #3 * Address Feedback #4 * Address Feedback #4 - Update documentation * Address Feedback #5 * Bug fix blinking of middle knob pos Fixed bug where middle knob pos wasn't being blinked correctly for patch cables in automation view
chee
pushed a commit
to chee/DelugeFirmware
that referenced
this pull request
Mar 23, 2024
…or Bipolar (SynthstromAudible#1480) * Make Gold Knob LED indicators + Automation View Editor Bipolar For bipolar params: 1) Made Gold Knob LED indicators bipolar 2) Made automation view editor bipolar Also added gold knob LED indicator functionality to automation view editor that makes blinks the middle value and makes it harder to turn the knob passed the middle value * Update documentation * Address Feedback SynthstromAudible#1 * Address Feedback SynthstromAudible#2 * Address Feedback SynthstromAudible#3 * Address Feedback SynthstromAudible#4 * Address Feedback SynthstromAudible#4 - Update documentation * Address Feedback SynthstromAudible#5 * Bug fix blinking of middle knob pos Fixed bug where middle knob pos wasn't being blinked correctly for patch cables in automation view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need to work out merge conflicts.