Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removed ENSG00000268104 from the following reaction GPRs: MAR053… #576

Merged
merged 1 commit into from
May 24, 2023

Conversation

jreimertz
Copy link
Collaborator

@jreimertz jreimertz commented May 22, 2023

Fix: Removed ENSG00000268104 from the following reaction GPRs: MAR05305, MAR05308, MAR05311, MAR05314, MAR05315, MAR05316, MAR05317, MAR05318, MAR05319, MAR05320, MAR05324, MAR05326, MAR05333, MAR06375, MAR06377, MAR06380, MAR06381, MAR06382, MAR06384, MAR08629, MAR08917, MAR11791 as referenced in Issue #567

Main improvements in this PR:

I removed ENSG00000268104 from the GPRs of 22 reactions (MAR05305, MAR05308, MAR05311, MAR05314, MAR05315, MAR05316, MAR05317, MAR05318, MAR05319, MAR05320, MAR05324, MAR05326, MAR05333, MAR06375, MAR06377, MAR06380, MAR06381, MAR06382, MAR06384, MAR08629, MAR08917, MAR11791) since these reactions do not include Cl- and ENSG00000268104 mediates transport of neutral and cationic amino acids in a Na+/Cl- dependent manner. Each of these reactions do not include Cl-.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

I did not see a dedicated file for removed GPRs so I did not include the above changes, if I missed it please let me know and I'll update it accordingly.

…05, MAR05308, MAR05311, MAR05314, MAR05315, MAR05316, MAR05317, MAR05318, MAR05319, MAR05320, MAR05324, MAR05326, MAR05333, MAR06375, MAR06377, MAR06380, MAR06381, MAR06382, MAR06384, MAR08629, MAR08917, MAR11791
@haowang-bioinfo
Copy link
Member

@jreimertz good job!

@haowang-bioinfo
Copy link
Member

haowang-bioinfo commented May 22, 2023

I did not see a dedicated file for removed GPRs so I did not include the above changes, if I missed it please let me know and I'll update it accordingly.

Everything is alright.

Note that curations to Human-GEM can be intuitively and conveniently made directly to the plain-txt model file Human-GEM.yml, exactly as you did here, since v1.3.1 (#156)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants