Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate metabolites identified by EHMN IDs #649

Merged
merged 9 commits into from
Jun 26, 2023

Conversation

JHL-452b
Copy link
Collaborator

@JHL-452b JHL-452b commented Jun 20, 2023

Main improvements in this PR:

As discussed in #616

  • remove mets MAM03354c, MAM03332c, MAM03332e for being duplicates
  • remove rxns MAR03441, MAR02588, MAR10164, MAR10433 for being affected by duplicate mets
  • change EHMN ID annotations for MAM01123c, MAM01123m, MAM01123x
  • replace mets
old ID new ID
MAM03354r MAM00131r
MAM00029c MAM00028c
MAM03368m MAM00748m
MAM03368x MAM00748x
MAM00902c MAM00853c

Also fix bugs of import and export cycle caused by the missing lines introduced in #662

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haowang-bioinfo haowang-bioinfo merged commit 4443e39 into SysBioChalmers:develop Jun 26, 2023
4 checks passed
@haowang-bioinfo haowang-bioinfo mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants