Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Duplicate Lipoic Acid Transport Reactions #706

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

Main improvements in this PR:

As proposed in #679:

  • Removes MAR01483 and MAR06406 for being less accurate duplicates of MAR09608
  • Merges annotations for MAR01483 and MAR06406 in reactions.tsv with those for MAR09608
  • Adds the RHEA accessions RHEA:73379 and RHEA:73380 to the annotations for MAR09608
  • Sets the references for MAR09608 to PMID:9516450;PMID:10329687;PMID:15561972

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@feiranl
Copy link
Collaborator

feiranl commented Oct 16, 2023

should we add the duplicated IDs to the reactions.tsv as @haowang-bioinfo did in #708

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haowang-bioinfo haowang-bioinfo merged commit 04837d1 into develop Oct 16, 2023
8 checks passed
@haowang-bioinfo haowang-bioinfo deleted the fix/lipoate_transport branch October 16, 2023 14:44
@haowang-bioinfo haowang-bioinfo mentioned this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants