Pgid trigger + Process Name Rework #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahabibi
force-pushed
the
pgid_trigger
branch
from
d067b3b
to
097f27b
Compare
added 3 commits
September 7, 2022 23:34
…supporting changes needed
… line endings on some log statements
jahabibi
force-pushed
the
pgid_trigger
branch
from
6fe8096
to
78ba30f
Compare
include/ProcDumpConfiguration.h
Outdated
|
|
||
| #include "Handle.h" | ||
| #include "TriggerThreadProcs.h" | ||
| #include "Process.h" | ||
| #include "Logging.h" | ||
|
|
||
| #define MAX_TRIGGERS 10 | ||
| #define MAX_TARGET_PROCESSES 256 |
There was a problem hiding this comment.
This doesn't seem to be used.
src/ProcDumpConfiguration.c
Outdated
| @@ -412,17 +481,27 @@ int GetOptions(struct ProcDumpConfiguration *self, int argc, char *argv[]) | |||
| } | |||
|
|
|||
|
|
|||
| if(self->ProcessId == NO_PID && !self->WaitingForProcessName){ | |||
| if(self->ProcessId == NO_PID && self->ProcessGroupId == NO_PID && !self->WaitingForProcessName){ | |||
| Log(error, "A valid PID or process name must be specified"); | |||
There was a problem hiding this comment.
"A valid PID, PGID or process name must be specified"
jahabibi
force-pushed
the
pgid_trigger
branch
from
43a817a
to
ee5c69e
Compare
MarioHewardt
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the logic to track all processes in a specified PGID group.