-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ST6RI-740 Syntax-related issues from SysML v2 FTF Ballot #11 #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Revised to only return the performedAction if this is different than the PerformActionUsage itself. Otherwise, the usual namingFeature is used.
- As well as all other changes called for in the issue resolution.
himi
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this PR by parsing below:
package ST6RI740 {
package SysML2_85 {
part p1 {
state s1;
action a1;
}
part p2 :> p1 {
exhibit state :>> s1;
perform action :>> a1;
}
}
package SysML2_553 {
case c1 {
objective o1 {
}
}
case c2 :> c1 {
objective o2 { // implicit redefinition to c1.o1
require constraint c1;
}
}
}
package SysML2_631 {
metadata def MD1;
metadata def MD2;
#MD1 #MD2 attribute a1 {
#MD1 @MD2;
}
}
package SysML2_637 {
metadata def MD1;
#MD1 enum def ED1 {
#MD1 a; // ERROR
b;
}
}
package SysML2_643 {
part p1 {
doc locale "en_US" /* Test */
doc locale "ja_JP" /* テスト */
comment locale "en_US" /* comment test */
comment locale "ja_JP" /* コメント */
}
}
package SysML2_783 {
part p1;
part p2;
connection c1 connect p1 to p2;
connection c2 {
end ::> p1;
end ::> p2;
}
}
package EXPAssociative {
attribute exp1 = 2 ^ 2 ^ 3;
attribute exp2 = (2 ^ 2) ^ 3;
attribute exp3 = 2 ^ (2 ^ 3);
}
}
I do not know the detailed plan but exhibit state does not have a proper effective name. (SysML2_85). |
IncludeUseCaseUsageImpl.
(Even though this was not actually included in the issue resolution.)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements resolutions of issues from SysML FTF Ballot 11 that called for updates to the SysML abstract and concrete syntax.
Resolutions of the following issues are implemented in this PR:
Note: The resolution to SYSML2-637 updated the SysML grammar so that user-defined keywords can be used on enumeration definitions. However, it did not update the grammar to allow such keywords on the enumerated value declarations within enumeration definitions. Nevertheless, the implementation in this PR does allow this, in the expectation that there will be a future FTF issue resolution to allow it formally. (Enumeration usage declarations other than for enumerated values already allowed user-defined keywords.)