-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tapis): core-cms v3 ui migration #191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
fix: tapis missing v1-v2 migration
fix: tapis missing ui migration
Aug 10, 2023
wesleyboar
changed the title
fix: tapis missing ui migration
fix: tapis core-cms v3 ui migration
Aug 10, 2023
wesleyboar
changed the title
fix: tapis core-cms v3 ui migration
fix(tapis): core-cms v3 ui migration
Aug 10, 2023
wesleyboar
commented
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved based on WI-6 comment. H.P. updated content rendered with the new styles, and told J.G. and I that the site is ready.
This was referenced Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add TAPIS UI to cover the Core-CMS migration from whatever it was to v3.
TAPIS site seems to have never been migrated to Core-CMS v2. Now it is has been migrated to Core-CMS-Custom and to Core-CMS v3. But it still lacks migration CSS that I hoped would fixed some UI bugs found during v3.11.4 testing. But applying the standard
site_cms/css/build/migrate.v1_v2.css
resulted in a very different style. So, I gave its own minimal migration styles.Related
Changes
assets_custom.html
to override Core-CMSmigrate.v1_v2.css
to load Core-CMS migration stylesTesting
Pre-Prod Should Look Similar to Prod Server
These items should match:
Padding on the titles for cards— caused by manual inline styles on prod#212529
vs#222222
).Known & Expected Differences
All v3 upgrades experience these approved differences (ref.):
<h1>
is missing on at least some pages.UI
Compare http://pprd.tapisproject.tacc.utexas.edu/ to http://tapis-project.org/.