Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tapis): core-cms v3 ui migration #191

Merged
merged 8 commits into from
Aug 15, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 10, 2023

Overview

Add TAPIS UI to cover the Core-CMS migration from whatever it was to v3.

TAPIS site seems to have never been migrated to Core-CMS v2. Now it is has been migrated to Core-CMS-Custom and to Core-CMS v3. But it still lacks migration CSS that I hoped would fixed some UI bugs found during v3.11.4 testing. But applying the standard site_cms/css/build/migrate.v1_v2.css resulted in a very different style. So, I gave its own minimal migration styles.

Related

Changes

  • added assets_custom.html to override Core-CMS
  • added migrate.v1_v2.css to load Core-CMS migration styles

Testing

Pre-Prod Should Look Similar to Prod Server

These items should match:

  1. Buttons on documentation page
  2. Padding on the titles for cards — caused by manual inline styles on prod
  3. Most dark text (the difference is subtle; #212529 vs #222222).
  4. The table on Training page (except for different color rows, which I think help legibility)
  5. Color of links (before and after hover).

Known & Expected Differences

All v3 upgrades experience these approved differences (ref.):

  1. Border underneath <h1> is missing on at least some pages.
  2. Font sizes.
  3. Font family.
  4. Heading size and space.
  5. Section spacing (negative space within a layout), because different inline styles.
  6. Heading size and space differ.
  7. Font that is regular weight and italic style is too thick.
  8. Breadcrumbs exist.
  9. Table styles.

UI

Compare http://pprd.tapisproject.tacc.utexas.edu/ to http://tapis-project.org/.

@wesleyboar wesleyboar changed the title fix: tapis missing v1-v2 migration fix: tapis missing ui migration Aug 10, 2023
@wesleyboar wesleyboar requested a review from taoteg August 10, 2023 21:55
@wesleyboar wesleyboar marked this pull request as ready for review August 10, 2023 21:55
@wesleyboar wesleyboar changed the title fix: tapis missing ui migration fix: tapis core-cms v3 ui migration Aug 10, 2023
@wesleyboar wesleyboar changed the title fix: tapis core-cms v3 ui migration fix(tapis): core-cms v3 ui migration Aug 10, 2023
Copy link
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved based on WI-6 comment. H.P. updated content rendered with the new styles, and told J.G. and I that the site is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant